Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(android): touchFeedbackColor not working for a bottomNavigation tab #14003

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

m1ga
Copy link
Contributor

@m1ga m1ga commented Mar 6, 2024

Currently the activeTintColor is used for the ripple color (our touchFeedbackColor) on a BottomNavigation Tab. The touchFeedbackColor is mentioned in the docs already but it doesn't have any effect.

This PR will check if that is set and will use it instead of the activeTintColor

Test

var win1 = Ti.UI.createWindow({
    backgroundColor: 'blue',
    title: 'Blue'
});
win1.add(Ti.UI.createLabel({text: 'I am a blue window.'}));

var win2 = Ti.UI.createWindow({
    backgroundColor: 'red',
    title: 'Red'
});
win2.add(Ti.UI.createLabel({text: 'I am a red window.'}));

var tab1 = Ti.UI.createTab({
    window: win1,
	title: 'Blue',
    touchFeedbackColor: "green"
}),
tab2 = Ti.UI.createTab({
    window: win2,
    activeTintColor: "red",
    touchFeedbackColor: "yellow",
    title: 'Red'
}),
tabGroup = Ti.UI.createTabGroup({
    tabs: [tab1, tab2],
    style: Titanium.UI.Android.TABS_STYLE_BOTTOM_NAVIGATION
});
tabGroup.open();

click the tabs and check the ripple color

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant