chore(android): try/catch around unlink snapshots #14000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hansemannn can we merge this one please. Really bugs me when testing different branches 😄 The file is not there and it tries to remove it. It just adds a try/catch (as some lines above it) so for normal builds it won't change anything. Have to do it by hand at the moment. Just a Linux SDK thing anyway since it is in |
cb1kenobi
reviewed
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as the unlink a few lines before: adding a try/catch around in case the file is not there.
Happened a few time when I've switched branches and did a
cleanbuildwhere it downloaded the v8 again.