-
Notifications
You must be signed in to change notification settings - Fork 607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated: Time & Weather (based on #2395) #2465
Conversation
Added additional weather APIs for user to choose between (AccuWeather, OpenWeather API 2.5, OpenWeather One Call API 3.0, Tomorrow.io, & Open-Meteo). Also added additional weather metrics and ability to animate through them based on what is selected. (Default is still set to wind speed)
According to the forum comment left here by @rohan (https://discuss.tidbyt.com/t/weather-app/5115/40), we are not able to leverage AccuWeather’s API per any Tidbyt community application. Therefore I am removing this.
All Set 🎉This change is ready to go! To merge your change, simply comment with a ( Manual Review RequiredHang tight! A Tidbyt engineer will be by shortly to review your change. Here is what they will be looking for:
|
@sudeepban – What are your thoughts on merging this PR in w/ yours? I added additional weather API's (since we cannot use AccuWeather) and added additional functionality as described in the PR's description. Hoping you're ok with how I've expanded upon your initial PR to add to your Time & Temp app. I'm sure some things could be improved, but hopefully this is a decent start. 😉 Also, was wondering if maybe it makes sense to rename this app to be "Time & Weather" or "Time & Current Weather Conditions", or something else to indicate that this update now displays more than just the current time and temperature. If you're comfortable with these changes, then we can try and get @matslina to approve. 🙂 |
@kaffolder7 that's very cool, nice work! I am definitely supportive of this and am glad to have you carry the torch and hopefully find a way to get this out with @matslina's approval. Appreciate the effort! |
Also no strong feelings about the name of the app, agree that Time & Temp seems limiting and am fine with a change there. |
Confirmed w/ original app author (@sudeepban) and permission given in PR comment.
Thanks for your kind feedback @sudeepban and approval. Let's see if @matslina can get around to reviewing and hopefully accepting/merging this into I also went ahead and changed the name of the app to better-reflect the functionality of this app. |
- Added: National Weather Service (NWS) & Weatherbit APIs - Cleaned up various items - Adjusted layout to better align within Tidbyt screen
nMgfdF+AGMzsmgD6BFiZq7TbbynZLVR3Pz6z7poaVKKT1rLJ+MsYAGKWVKuIhuN3 | ||
AAAAAElFTkSuQmCC | ||
""", | ||
"foggy.png": """ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can try running exiftool -all=
on assets like these to trim down their size by removing EXIF data. On this particular one, it drops from 2.8k to 212 bytes.
This PR is based on @sudeepban's initial work in PR #2395.
Changes / additions
Preview
Initial app load state (before API key is entered):
Preview when a single weather metric is enabled (e.g. 'wind speed'):
Preview when multiple weather metrics are enabled (e.g. 'wind speed', 'humidity', 'dew point', 'cloud coverage', & 'pressure'):