Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AFL] updates to reduce render time, add standings option #2463

Merged
merged 1 commit into from
May 22, 2024

Conversation

jmanske
Copy link
Contributor

@jmanske jmanske commented May 13, 2024

@henrygg98 tried to add a new feature in #2375 to show standings in the AFL app, but the slow render times wouldn't allow his changes to go through. I think I have made sufficient changes to it to allow for it to render in under a second in most cases and added the option he wanted as well. Tagging app author @andymcrae in case he wants to review as well.

@jmanske jmanske requested a review from matslina as a code owner May 13, 2024 10:28
@tidbyt
Copy link

tidbyt bot commented May 13, 2024

⚠️ The automated review process is experimental and likely has bugs. Please bear with us as we iron out the kinks and enable you to ship changes at high velocity 🚀

Next Steps

Hello! Thank you so much for your change 🤜 🤛 . There are a few things you need to do:

  • Sign the CLA if you haven't already
  • Ensure your build is green! Any problem will display a proposed solution to try out
  • Get a review, either by Tidbyt Bot or by a Tidbyt engineer

Manual Review Required

Hang tight! A Tidbyt engineer will be by shortly to review your change. Here is what they will be looking for:

Test Details
App Dir All files are in a single app directory
🟡 Modules Usage of http.star requires review
🟡 Original Author The original author (andymcrae) does not match the PR author (jmanske)

@matslina matslina merged commit 67ce787 into tidbyt:main May 22, 2024
2 checks passed
@tidbyt tidbyt locked as resolved and limited conversation to collaborators May 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants