Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spot station adjustment #2460

Merged
merged 11 commits into from
May 22, 2024
Merged

Spot station adjustment #2460

merged 11 commits into from
May 22, 2024

Conversation

rjison
Copy link
Contributor

@rjison rjison commented May 11, 2024

Add instructions option
Display the next sighting display up until it has completely passed by, instead of moving on at the start of the fly by.

@rjison rjison requested a review from matslina as a code owner May 11, 2024 04:28
@tidbyt
Copy link

tidbyt bot commented May 11, 2024

⚠️ The automated review process is experimental and likely has bugs. Please bear with us as we iron out the kinks and enable you to ship changes at high velocity 🚀

Next Steps

Hello! Thank you so much for your change 🤜 🤛 . There are a few things you need to do:

  • Sign the CLA if you haven't already
  • Ensure your build is green! Any problem will display a proposed solution to try out
  • Get a review, either by Tidbyt Bot or by a Tidbyt engineer

Manual Review Required

Hang tight! A Tidbyt engineer will be by shortly to review your change. Here is what they will be looking for:

Test Details
App Dir All files are in a single app directory
🟡 Modules Usage of http.star requires review
Original Author The original author matches the PR author

@matslina matslina merged commit b939e33 into tidbyt:main May 22, 2024
2 checks passed
@tidbyt tidbyt locked as resolved and limited conversation to collaborators May 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants