Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added: optional clock #2445

Merged
merged 6 commits into from
May 17, 2024
Merged

Added: optional clock #2445

merged 6 commits into from
May 17, 2024

Conversation

kaffolder7
Copy link
Contributor

Added additional feature to display the active time (clock) as this is helpful in my case. I have been using this app as the only app on my Tidbyt at nighttime instead of the default built-in, nighttime display of the time. Great initial app by @alan-fleming!! 🎉 Happy to share and opening a PR as I think this feature may also be helpful to others as well.

@kaffolder7 kaffolder7 requested a review from matslina as a code owner May 6, 2024 14:59
@tidbyt
Copy link

tidbyt bot commented May 6, 2024

⚠️ The automated review process is experimental and likely has bugs. Please bear with us as we iron out the kinks and enable you to ship changes at high velocity 🚀

Next Steps

Hello! Thank you so much for your change 🤜 🤛 . There are a few things you need to do:

  • Sign the CLA if you haven't already
  • Ensure your build is green! Any problem will display a proposed solution to try out
  • Get a review, either by Tidbyt Bot or by a Tidbyt engineer

Manual Review Required

Hang tight! A Tidbyt engineer will be by shortly to review your change. Here is what they will be looking for:

Test Details
App Dir All files are in a single app directory
Modules Only safe modules, without side-effects, are loaded
🟡 Original Author The original author (alan-fleming) does not match the PR author (kaffolder7)

@tidbyt-bot
Copy link

tidbyt-bot commented May 6, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@kaffolder7
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@kaffolder7
Copy link
Contributor Author

@alan-fleming – Would you be willing to review this PR? Git bot states that a manual review is required since obviously I am not the original author.

I added a clock to your Phase of Moon app as I found that was one thing I was desiring. Opening my changes as a PR so others can hopefully benefit from the addition. (FYI: I added some schema configuration to the app so that this can be enabled/disabled. Defaults are configured to phase of moon text w/ optional clock.)

@alan-fleming
Copy link
Contributor

Hi there. Apologies for the delay, I've been travelling with work and my time has not been my own. I'm OK with these changes.

@kaffolder7
Copy link
Contributor Author

kaffolder7 commented May 17, 2024

Hi there. Apologies for the delay, I've been travelling with work and my time has not been my own. I'm OK with these changes.

Thanks so much!! 😀

@matslina or @rohansingh, can we get this PR merged in? tidbyt bot says that manual review is required because original author (@alan-fleming) does not match PR author (me). (FYI: Alan has approved the added feature.)

@rohansingh rohansingh merged commit caea72e into tidbyt:main May 17, 2024
2 checks passed
@kaffolder7
Copy link
Contributor Author

I so appreciate you @rohansingh! 🫶 I know Mats probably has a LOT going on right now. Was wanting to get this merged since my fork was held up by some other PR's I'd like to submit. (I was dumb and didn't branch my fork with these changes. I'll create branches on my fork and submit those as PR in the future.)

@rohansingh
Copy link
Member

@kaffolder7 Thanks for the PR! Yeah we are both swamped right now, working on firmware/software for Gen 2.

@tidbyt tidbyt locked as resolved and limited conversation to collaborators May 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants