Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft Steam Top Sellers app #2443

Merged
merged 2 commits into from
May 22, 2024

Conversation

johnkalbac
Copy link
Contributor

Draft proposal for a "Steam Top Sellers" app. This simply renders a random selection from Steam's Top Sellers list, including the game name, price, (optional) discount and an image.

There are some notes for improvements and quality-of-life enhancements. Specifically, the caching and animation timing may use further refinement. The animation quality/length was also significantly reduced to keep the rendered file size under the required limit.

There are no configuration parameters required at this point.

Open to suggestions/feedback. Also including a preview image:

steam_top_sellers

@johnkalbac johnkalbac requested a review from matslina as a code owner May 5, 2024 19:50
@tidbyt
Copy link

tidbyt bot commented May 5, 2024

⚠️ The automated review process is experimental and likely has bugs. Please bear with us as we iron out the kinks and enable you to ship changes at high velocity 🚀

Next Steps

Hello! Thank you so much for your change 🤜 🤛 . There are a few things you need to do:

  • Sign the CLA if you haven't already
  • Ensure your build is green! Any problem will display a proposed solution to try out
  • Get a review, either by Tidbyt Bot or by a Tidbyt engineer

Manual Review Required

Hang tight! A Tidbyt engineer will be by shortly to review your change. Here is what they will be looking for:

Test Details
App Dir All files are in a single app directory
🟡 Modules Usage of animation.star requires review
Original Author The original author matches the PR author

@tidbyt-bot
Copy link

tidbyt-bot commented May 5, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@johnkalbac
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@matslina matslina merged commit ea7fa3b into tidbyt:main May 22, 2024
2 checks passed
@tidbyt tidbyt locked as resolved and limited conversation to collaborators May 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants