Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submit new app Custom Quotes #2433

Merged
merged 8 commits into from
May 22, 2024
Merged

Submit new app Custom Quotes #2433

merged 8 commits into from
May 22, 2024

Conversation

vipulchhajer
Copy link
Contributor

Users can store their favorite quotes in a google sheet and use this app to display them on tidbyt.

@tidbyt
Copy link

tidbyt bot commented May 2, 2024

⚠️ The automated review process is experimental and likely has bugs. Please bear with us as we iron out the kinks and enable you to ship changes at high velocity 🚀

Next Steps

Hello! Thank you so much for your change 🤜 🤛 . There are a few things you need to do:

  • Sign the CLA if you haven't already
  • Ensure your build is green! Any problem will display a proposed solution to try out
  • Get a review, either by Tidbyt Bot or by a Tidbyt engineer

Manual Review Required

Hang tight! A Tidbyt engineer will be by shortly to review your change. Here is what they will be looking for:

Test Details
App Dir All files are in a single app directory
🟡 Modules Usage of http.star requires review
Original Author The original author matches the PR author

@vipulchhajer
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@vipulchhajer
Copy link
Contributor Author

Hi @matslina May I bother you for a PR review? Thanks!

@vipulchhajer
Copy link
Contributor Author

vipulchhajer commented May 17, 2024

Hi @matslina and @rohansingh May I please bother either of you for a PR review? Thanks!

apps/customquotes/custom_quotes.star Outdated Show resolved Hide resolved
apps/customquotes/manifest.yaml Outdated Show resolved Hide resolved
@vipulchhajer
Copy link
Contributor Author

@rohansingh I have made the requested changes based on your feedback. Please take another look when you have a chance.

@matslina matslina merged commit 513b85a into tidbyt:main May 22, 2024
2 checks passed
@tidbyt tidbyt locked as resolved and limited conversation to collaborators May 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants