Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New app: Packt Pub free ebook of the day #2410

Merged
merged 1 commit into from
May 22, 2024

Conversation

danielsitnik
Copy link
Contributor

@danielsitnik danielsitnik commented Apr 23, 2024

Description

This app displays the cover, name and number of pages of the free eBook of the day from Packt Pub's website: https://www.packtpub.com/free-learning

The native cache module was used here because I wanted to have a "dynamic ttl", which is currently not supported by the http cache module. See this Pixlet PR for more details: tidbyt/pixlet#1048

Copilot

copilot:all

@tidbyt
Copy link

tidbyt bot commented Apr 23, 2024

⚠️ The automated review process is experimental and likely has bugs. Please bear with us as we iron out the kinks and enable you to ship changes at high velocity 🚀

Next Steps

Hello! Thank you so much for your change 🤜 🤛 . There are a few things you need to do:

  • Sign the CLA if you haven't already
  • Ensure your build is green! Any problem will display a proposed solution to try out
  • Get a review, either by Tidbyt Bot or by a Tidbyt engineer

Manual Review Required

Hang tight! A Tidbyt engineer will be by shortly to review your change. Here is what they will be looking for:

Test Details
App Dir All files are in a single app directory
🟡 Modules Usage of html.star requires review
Original Author The original author matches the PR author

Previews

apps/packtfreeebook/packt_free_ebook.star:

@matslina matslina merged commit 3989a32 into tidbyt:main May 22, 2024
2 checks passed
@matslina
Copy link
Contributor

Looks like packtpub.com is down atm, which unfortunately blocks the deployment pipe. Might have to revert this for now @danielsitnik.

@danielsitnik
Copy link
Contributor Author

Yep, just tested it here and it seems their website is really down at the moment 😢

matslina added a commit that referenced this pull request May 22, 2024
matslina added a commit that referenced this pull request May 22, 2024
@danielsitnik
Copy link
Contributor Author

@matslina their site is back! 😉

@tidbyt tidbyt locked as resolved and limited conversation to collaborators May 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants