-
Notifications
You must be signed in to change notification settings - Fork 608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New App: Next Event #2409
New App: Next Event #2409
Conversation
Next StepsHello! Thank you so much for your change 🤜 🤛 . There are a few things you need to do:
Manual Review RequiredHang tight! A Tidbyt engineer will be by shortly to review your change. Here is what they will be looking for:
Previews |
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
I have read the CLA Document and I hereby sign the CLA |
@mattcaruso I'm glad I inspired this. One quick note I haven't been able to resolve, even though it seems my code works, the way the Tidbyt updates (or doesn't) means it only shows the correct next event once. If you have the same issue, or if you figured out a solution, I'd love to hear! I haven't had the time to look into it. |
@quesurifn Thanks for calling that out. Because of the way Tidbyt prevents you from "private publishing" outside of manually pushing updates via the API, I haven't been able to QA the app long enough to see that behavior. I'll keep an eye out for it and will think on it if it occurs. |
@mattcaruso @quesurifn Could you guys elaborate a bit on these Lambda functions? Are they just there to aid in parsing ics? @quesurifn Could you provide more detail on the issue you mentioned about how "Tidbyt updates (or doesn't)"? Also, @mattcaruso, private app hosting is available, but requires a subscription. |
@matslina The lambda parses the ICS. Unfortunately for starlink, even though it's implemented in Go, we cannot add our own modules. So for more complex functionality, things like Lambdas are required. In terms of updating, the UniversalIcal app has a bug where only the first status is showed. It doesn't update after. I'm not sure if that's due to the latency of the lambda on a cold start or because of the way the tidbyt updates. |
Pixlet is FOSS, and I think something like an ics parser would be a great addition. Unless there's some technical limitation I'm unaware of, it should be easy to add.
Not sure about the lambda, but Tidbyt apps are run each time they're displayed, and they run in an environment that's very similar to what you have locally with Pixlet. There are some differences in caching that might come into play, but not sure how that would happen exactly. I can try to take a look later today. |
@matslina That would be great. I do think the Tidbyt might be hitting a timeout with the lambda and displaying the last image. What exactly is FOSS? |
Free and Open Source Software. And that sounds like a plausible explanation. Unless explicitly instructed via the |
@matslina Do you guys have a procedure for extending pixlet or documentation? Not a project I can take on now, but when I free up it does sound interesting. |
Just submit a PR! Of course always a good idea to get some input on design and such before investing tons of time into it, just in case there's some issue that prevents us from merging. Discord is a great place for connecting with other community devs, and there's plenty of folks there who have enough experience with pixlet etc to give quality feedback. |
@matslina Here's the Lambda function code used in my app, related to this PR. |
Took a quick look at iCal, and wow, yeah, adding support to Pixlet would not be entirely trivial. Might need some caching to get acceptable performance, as these ics files can get pretty large. My personal Google Calendar export is almost 1MB, reaching back to 2015. For now, I'd like to at least add the suggested warning about how the data's processed in the app description. And @quesurifn would you mind doing the same on your app? I want it to be clear to users that their data is being processed by an external service. |
Co-authored-by: Mats Linander <matslina@gmail.com>
@matslina I'll update it when I get a chance. |
@matslina Hello! Any other actions needed to get this one released? |
Description
This new app displays the next date in an iCalendar (ics) calendar when an event will occur. The other calendar options available from the community all focused on daily schedules and would often show "No more events today" (or similar) if there were no events in the connected calendar left on that day. For my use case, I want to display the next day when there's an event coming up, such as a calendar feed of concerts, shows, birthdays, or holidays!
Thanks to @quesurifn whose Universal iCal app heavily inspired the architecture of this app.
(PS: The code for the Lambda function referenced in this Pixlet app will also be open sourced soon. I'll submit a new PR when I can link to it directly in the code comments for future creators to see how I'm handling the server-side functionality).
Copilot
copilot:all