Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update solaredge_monitor.star #2406

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update solaredge_monitor.star #2406

wants to merge 1 commit into from

Conversation

wfmer
Copy link

@wfmer wfmer commented Apr 21, 2024

updated the URL for the api as it has changed in the last year since the app was initially developed.

Description

Per the discussion, on-going 'https://discuss.tidbyt.com/t/solaredgemonitor-not-working/4926' - I updated the URL for the api call and added a comment out-linning in an attempt to rectify the app as it currently displaying the default 3.14/4.71/1.57 values, without change. Despite, like many, having generated new api keys and confirming their accuracy in the solaredge module of the tidbyt app.

Copilot

copilot:all

updated the URL for the api as it has changed in the last year since the app was initially developed.
@wfmer wfmer requested a review from matslina as a code owner April 21, 2024 22:45
@tidbyt
Copy link

tidbyt bot commented Apr 21, 2024

⚠️ The automated review process is experimental and likely has bugs. Please bear with us as we iron out the kinks and enable you to ship changes at high velocity 🚀

Next Steps

Hello! Thank you so much for your change 🤜 🤛 . There are a few things you need to do:

  • Sign the CLA if you haven't already
  • Ensure your build is green! Any problem will display a proposed solution to try out
  • Get a review, either by Tidbyt Bot or by a Tidbyt engineer

Manual Review Required

Hang tight! A Tidbyt engineer will be by shortly to review your change. Here is what they will be looking for:

Test Details
App Dir All files are in a single app directory
🟡 Modules Usage of cache.star requires review
🟡 Original Author The original author (marcusb) does not match the PR author (wfmer)

Previews

apps/solaredgemonitor/solaredge_monitor.star:

@tidbyt-bot
Copy link

tidbyt-bot commented Apr 21, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@wfmer
Copy link
Author

wfmer commented Apr 21, 2024

I have read the CLA Document and I hereby sign the CLA

@matslina
Copy link
Contributor

@marcusb Cool to merge this one?

@marcusb
Copy link
Contributor

marcusb commented May 6, 2024

@marcusb Cool to merge this one?

-1. The v2 API is totally different from v1. This will need a rewrite.

@stale stale bot added the wontfix label Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants