-
Notifications
You must be signed in to change notification settings - Fork 608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LastFM stats updated ID and API key #2390
Conversation
Next StepsHello! Thank you so much for your change 🤜 🤛 . There are a few things you need to do:
Manual Review RequiredHang tight! A Tidbyt engineer will be by shortly to review your change. Here is what they will be looking for:
Previews |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey. Changing the app ID will unfortunately break all existing installations, and generally cause mayhem behind the scenes in the production environment. The changes I proposed should repair the secrets, which as you wrote was encrypted using directory name instead of app ID as key.
Co-authored-by: Mats Linander <matslina@gmail.com>
Co-authored-by: Mats Linander <matslina@gmail.com>
Ok, wasn't sure how that would work exactly. I committed the changes you proposed. Thank you! |
@matslina Friendly bump. Any other changes you are looking for? |
@skinner452 Sorry for the delay! Another busy couple of weeks over here... |
Description
After the last API key update, the app was no longer listed. This PR updates the ID to match the folder name so I don't need to worry about any mismatch. Also regenerated the API key again just in case.
Copilot
copilot:all