Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LastFM stats updated ID and API key #2390

Merged
merged 3 commits into from
May 22, 2024

Conversation

skinner452
Copy link
Contributor

Description

After the last API key update, the app was no longer listed. This PR updates the ID to match the folder name so I don't need to worry about any mismatch. Also regenerated the API key again just in case.

Copilot

copilot:all

@tidbyt
Copy link

tidbyt bot commented Apr 13, 2024

⚠️ The automated review process is experimental and likely has bugs. Please bear with us as we iron out the kinks and enable you to ship changes at high velocity 🚀

Next Steps

Hello! Thank you so much for your change 🤜 🤛 . There are a few things you need to do:

  • Sign the CLA if you haven't already
  • Ensure your build is green! Any problem will display a proposed solution to try out
  • Get a review, either by Tidbyt Bot or by a Tidbyt engineer

Manual Review Required

Hang tight! A Tidbyt engineer will be by shortly to review your change. Here is what they will be looking for:

Test Details
App Dir All files are in a single app directory
🟡 Modules Usage of animation.star requires review
Original Author The original author matches the PR author

Previews

apps/lastfmstats/lastfmstats.star:

Copy link
Contributor

@matslina matslina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey. Changing the app ID will unfortunately break all existing installations, and generally cause mayhem behind the scenes in the production environment. The changes I proposed should repair the secrets, which as you wrote was encrypted using directory name instead of app ID as key.

apps/lastfmstats/manifest.yaml Outdated Show resolved Hide resolved
apps/lastfmstats/lastfmstats.star Outdated Show resolved Hide resolved
skinner452 and others added 2 commits April 25, 2024 13:24
Co-authored-by: Mats Linander <matslina@gmail.com>
Co-authored-by: Mats Linander <matslina@gmail.com>
@skinner452
Copy link
Contributor Author

Hey. Changing the app ID will unfortunately break all existing installations, and generally cause mayhem behind the scenes in the production environment. The changes I proposed should repair the secrets, which as you wrote was encrypted using directory name instead of app ID as key.

Ok, wasn't sure how that would work exactly. I committed the changes you proposed. Thank you!

@skinner452
Copy link
Contributor Author

@matslina Friendly bump. Any other changes you are looking for?

@matslina matslina merged commit dc07a1b into tidbyt:main May 22, 2024
2 checks passed
@matslina
Copy link
Contributor

@skinner452 Sorry for the delay! Another busy couple of weeks over here...

@tidbyt tidbyt locked as resolved and limited conversation to collaborators May 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants