Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New app: NOS (Dutch news ticker) #2360

Merged
merged 5 commits into from
May 22, 2024
Merged

New app: NOS (Dutch news ticker) #2360

merged 5 commits into from
May 22, 2024

Conversation

PMK
Copy link
Contributor

@PMK PMK commented Mar 29, 2024

Description

This new app shows random one of the latest news items from the Dutch website nos.nl. This will show as a news ticker in Dutch. You can also optionally specify a news category.

Data provided by Nos.nl.

Copilot

copilot:all

@tidbyt
Copy link

tidbyt bot commented Mar 29, 2024

⚠️ The automated review process is experimental and likely has bugs. Please bear with us as we iron out the kinks and enable you to ship changes at high velocity 🚀

Next Steps

Hello! Thank you so much for your change 🤜 🤛 . There are a few things you need to do:

  • Sign the CLA if you haven't already
  • Ensure your build is green! Any problem will display a proposed solution to try out
  • Get a review, either by Tidbyt Bot or by a Tidbyt engineer

Manual Review Required

Hang tight! A Tidbyt engineer will be by shortly to review your change. Here is what they will be looking for:

Test Details
App Dir All files are in a single app directory
🟡 Modules Usage of http.star requires review
Original Author The original author matches the PR author

@PMK PMK marked this pull request as ready for review March 29, 2024 16:20
@PMK PMK requested a review from matslina as a code owner March 29, 2024 16:20
@matslina matslina merged commit c378ec4 into tidbyt:main May 22, 2024
2 checks passed
@tidbyt tidbyt locked as resolved and limited conversation to collaborators May 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants