Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ShellPkg: Changes to print Type17 in Smbiosview #5620

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

shenbagadevir
Copy link

Add changes to print PMIC and RCD details of Smbios Type17 in Shell smbiosview command.

Cc: Gaoliming gaoliming@byosoft.com.cn
Cc: Sainadh N sainadhn@ami.com
Cc: Sundaresan S sundaresans@ami.com
Cc: Srinivasan M srinivasanm@ami.com
Cc: Ramesh R rameshr@ami.com
Cc: Karthika R karthikar@ami.com

Reviewed-by: Giri Mudusuru girimudusuru@microsoft.com

Add changes to print PMIC and RCD details of Smbios Type17 in Shell
smbiosview command.

Cc: Gaoliming <gaoliming@byosoft.com.cn>
Cc: Sainadh N <sainadhn@ami.com>
Cc: Sundaresan S <sundaresans@ami.com>
Cc: Srinivasan M <srinivasanm@ami.com>
Cc: Ramesh R <rameshr@ami.com>
Cc: Karthika R <karthikar@ami.com>

Signed-off-by: Shenbagadevi R <shenbagadevir@ami.com>
Reviewed-by: Giri Mudusuru <girimudusuru@microsoft.com>
@shenbagadevir
Copy link
Author

Hi @GiriM123 ,

Facing build errors
ERROR - Compiler #error from /__w/1/s/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c ‘SMBIOS_TABLE_TYPE17’ has no member named ‘Pmic0ManufacturerID’; did you mean ‘ModuleManufacturerID’?
ERROR - Compiler #error from /__w/1/s/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c ‘SMBIOS_TABLE_TYPE17’ has no member named ‘Pmic0RevisionNumber’
ERROR - Compiler #error from /__w/1/s/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c ‘SMBIOS_TABLE_TYPE17’ has no member named ‘RcdManufacturerID’; did you mean ‘Manufacturer’?
ERROR - Compiler #error from /__w/1/s/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c ‘SMBIOS_TABLE_TYPE17’ has no member named ‘RcdRevisionNumber’
ERROR - Compiler #7000 from : Failed to execute command
ERROR - EDK2 #2 from : Failed to build module
CRITICAL - Build failed

But all these members are defined in SMBIOS_TABLE_TYPE17 structure in SmBios.h of MdePkg and created merge request for the same.
Please help to review this and merge.

Cc: @lgao4
Cc: @sainadhnagolu

Thanks,
Shenba

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant