Lockbox #5609
Open
Lockbox #5609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xieyuanh
force-pushed
the
dev/yuanhao/lockbox
branch
5 times, most recently
from
6ffe6e0
to
72efda4
Compare
|
|
xieyuanh
force-pushed
the
dev/yuanhao/lockbox
branch
from
72efda4
to
ee7f09d
Compare
niruiyu
reviewed
Apr 30, 2024
| @@ -38,6 +38,7 @@ | |||
| MmServicesTableLib | |||
| BaseLib | |||
| DebugLib | |||
| StandaloneMmDriverEntryPoint | |||
There was a problem hiding this comment.
Why a lib needs to depend on DriverEntryPoint?
niruiyu
reviewed
Apr 30, 2024
| #include <Protocol/LockBox.h> | ||
| #include <Guid/SmmLockBox.h> | ||
|
|
||
| extern BOOLEAN mLocked; |
There was a problem hiding this comment.
I feel "extern BOOLEAN mLocked" is not needed.
xieyuanh
force-pushed
the
dev/yuanhao/lockbox
branch
from
ee7f09d
to
2934b80
Compare
|
|
The LockBox Dependency DXE Driver is designed for use with standalone mm where gBS are not accessible to indicates that LockBox API is ready for use. For DXE drivers use lockbox APIs via a communication mechanism triggering an SMI, it's must to have the corresponding SMI handler pre-installed for interrupt management. To ensure orderly operations and proper notification, besides specified the guid in the [Depex] section of the .inf file. The installation of smi handler, along with the LockBox protocol marked by gEfiLockBoxProtocolGuid, must be informed to the DXE driver. This protocol installation signifies to the DXE driver that the LockBox API is ready for use. Cc: Liming Gao <gaoliming@byosoft.com.cn> Cc: Jiaxin Wu <jiaxin.wu@intel.com> Cc: Ray Ni <ray.ni@intel.com> Signed-off-by: Yuanhao Xie <yuanhao.xie@intel.com>
The Lockbox Driver allows sensitive data to be securely stored in a designated area, thus protected against unauthorized access. This patch does not introduce any functional modifications. It refactors the existing logic into a common component to facilitates the integration of the Standalone MM Lockbox Driver in an upcoming patch Cc: Liming Gao <gaoliming@byosoft.com.cn> Cc: Jiaxin Wu <jiaxin.wu@intel.com> Cc: Ray Ni <ray.ni@intel.com> Signed-off-by: Yuanhao Xie <yuanhao.xie@intel.com>
The Lockbox Driver allows sensitive data to be securely stored in a designated area, thus protected against unauthorized access. This patch adds a Standalone MM Lockbox Driver with main modifications: 1. Separating shared code between the Standalone MM driver and the DXE MM Driver. 2. Utilizing services from the SMM Services Table (gSmst) as opposed to relying on Boot Services. Cc: Liming Gao <gaoliming@byosoft.com.cn> Cc: Jiaxin Wu <jiaxin.wu@intel.com> Cc: Ray Ni <ray.ni@intel.com> Signed-off-by: Yuanhao Xie <yuanhao.xie@intel.com>
xieyuanh
force-pushed
the
dev/yuanhao/lockbox
branch
from
2934b80
to
b01f26f
Compare
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.