Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor SettingsImporter [3/x] #7809

Merged
merged 3 commits into from
May 7, 2024
Merged

Refactor SettingsImporter [3/x] #7809

merged 3 commits into from
May 7, 2024

Conversation

cketti
Copy link
Member

@cketti cketti commented May 3, 2024 •
edited

This is a first step in cleaning up SettingsFileParser.

(The next step is to make SettingsFileParser stricter, so most properties in SettingsFile.* can be non-nullable, which in turn should help clean up SettingsImporter.)

Previously:

@cketti cketti requested a review from wmontwe as a code owner May 3, 2024 17:42
wmontwe
wmontwe approved these changes May 7, 2024
View reviewed changes
Copy link
Collaborator

@wmontwe wmontwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@cketti cketti merged commit e9cc920 into main May 7, 2024
2 checks passed
@cketti cketti deleted the clean_up_SettingsFileParser branch May 7, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wmontwe wmontwe wmontwe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cketti @wmontwe