Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ADR white label architecture #7805

Merged
merged 1 commit into from
May 3, 2024
Merged

Add ADR white label architecture #7805

merged 1 commit into from
May 3, 2024

Conversation

wmontwe
Copy link
Collaborator

@wmontwe wmontwe commented May 3, 2024 •
edited

This ADR describes the white-label architecture to support two applications, namingly Thunderbird for Android and K-9 Mail, from one source repository.

@wmontwe wmontwe added the type: architecture Architecture of the project and high level design label May 3, 2024
@wmontwe wmontwe requested a review from cketti as a code owner May 3, 2024 10:13
@wmontwe wmontwe force-pushed the add-adr-whitelabel-architecture branch 3 times, most recently from 2761594 to a695ef0 Compare May 3, 2024 10:21
@wmontwe wmontwe changed the base branch from add-adr-central-project-configuration to main May 3, 2024 10:22
@wmontwe wmontwe force-pushed the add-adr-whitelabel-architecture branch from a695ef0 to 19fafee Compare May 3, 2024 10:39
@wmontwe wmontwe mentioned this pull request May 3, 2024
Open
7 tasks
@wmontwe wmontwe force-pushed the add-adr-whitelabel-architecture branch from 19fafee to 532251a Compare May 3, 2024 10:52
@cketti
Copy link
Member

cketti commented May 3, 2024

We have quite a few modules named "common" in our project. To avoid confusion I think we should use Gradle's colon notation to refer to modules. So :app-k9mail, :app-thunderbird, and :app:common.

@wmontwe
Copy link
Collaborator Author

wmontwe commented May 3, 2024

We have quite a few modules named "common" in our project. To avoid confusion I think we should use Gradle's colon notation to refer to modules. So :app-k9mail, :app-thunderbird, and :app:common.

At the moment it is hidden in the app module and I thought to give it more prominence by moving it to the project root. Maybe app-common would be beneficial.

I'm about to prepare another ADR for the general project structure, where I wanted to rename the app module to legacy to highlight that code should be moved out of there.

@cketti
Copy link
Member

cketti commented May 3, 2024

At the moment it is hidden in the app module and I thought to give it more prominence by moving it to the project root. Maybe app-common would be beneficial.

I like that. I think :app-common would provide more context than simply naming it :common.

@wmontwe
Copy link
Collaborator Author

wmontwe commented May 3, 2024

Update to app-common

@wmontwe wmontwe force-pushed the add-adr-whitelabel-architecture branch from 42b4320 to 37c77d7 Compare May 3, 2024 14:24
@wmontwe wmontwe merged commit 61af35b into main May 3, 2024
1 check passed
@wmontwe wmontwe deleted the add-adr-whitelabel-architecture branch May 3, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cketti cketti cketti approved these changes

Assignees
No one assigned
Labels
type: architecture Architecture of the project and high level design
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wmontwe @cketti