fix: latest --all correctly reports uninstalled plugins as missing

Fixes the bug reported at asdf-vm#1096.
threkk · Dec 8, 2021 · a08cadc · a08cadc
1 parent 42a2321
commit a08cadc
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 2 deletions.
diff --git a/lib/commands/command-latest.bash b/lib/commands/command-latest.bash
@@ -73,7 +73,7 @@ latest_all() {
       local installed_versions
       installed_versions=$(list_installed_versions "$plugin_name")
 
-      if ! printf '%s\n' "$installed_versions" | grep -q "^$version\$"; then
+      if [ -n "$installed_versions" ] && printf '%s\n' "$installed_versions" | grep -q "^$version\$"; then
         installed_status="installed"
       fi
       printf "%s\\t%s\\t%s\\n" "$plugin_name" "$version" "$installed_status"

diff --git a/test/latest_command.bats b/test/latest_command.bats
@@ -64,7 +64,16 @@ teardown() {
 ####      latest --all      ####
 ################################
 @test "[latest_command - all plugins] shows the latest stable version of all plugins" {
+  run asdf install dummy 2.0.0
+  run asdf install legacy-dummy 1.0.0
   run asdf latest --all
-  [ "$(echo -e "dummy\t2.0.0\tinstalled\nlegacy-dummy\t2.0.0\tinstalled\n")" == "$output" ]
+  echo "output $output"
+  [ "$(echo -e "dummy\t2.0.0\tinstalled\nlegacy-dummy\t2.0.0\tmissing\n")" == "$output" ]
+  [ "$status" -eq 0 ]
+}
+
+@test "[latest_command - all plugins] not installed plugin should return missing" {
+  run asdf latest --all
+  [ "$(echo -e "dummy\t2.0.0\tmissing\nlegacy-dummy\t2.0.0\tmissing\n")" == "$output" ]
   [ "$status" -eq 0 ]
 }