Add Windows support #631
Open
Add Windows support #631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add colorama and pyreadline to the dependency list if the running operating system is Windows.
Initialize colorama if the running operating system is Windows, so colored output can be correctly displayed to Windows's command prompt.
Add "Additional requirements for Windows" subsection to "Requirements"; Add "Installation on Windows" subsection to "Installation".
Prevent is_libedit from raising "Type Error: argument of type 'NoneType' is not iterable" when running on Windows with pyreadline instead of default readline module.
|
Checks does not pass, please fix it according to what travis says. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
READY
Description
This pull request adds support for Windows by initializing colorama when loading the interpreter module, so colored output can be printed to Windows's command prompt, and by using pyreadline on Windows systems as a replacement for Linux's readline module.
Closes Issue #619
Verification
Provide steps to test or reproduce the PR.
git clone https://github.com/threat9/routersploit && cd routersploitpython3 setup.py installrsfChecklist