bugfixes: Backtester credentials, Binance ExecutionLimits, Mock recording #1539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1539 +/- ##
==========================================
- Coverage 36.03% 35.91% -0.13%
==========================================
Files 412 409 -3
Lines 177779 177453 -326
==========================================
- Hits 64060 63729 -331
- Misses 105868 105871 +3
- Partials 7851 7853 +2
|
thrasher-
requested changes
May 15, 2024
backtester/engine/setup.go
Outdated
| base.API.AuthenticatedSupport = validated | ||
| if !validated { | ||
| return fmt.Errorf("%v %w", base.GetName(), errInvalidCredentials) | ||
| creds, err := base.GetCredentials(context.TODO()) |
There was a problem hiding this comment.
Suggested change
| creds, err := base.GetCredentials(context.TODO()) | |
| _, err := base.GetCredentials(context.TODO()) | |
| if err != nil { | |
| return err | |
| } |
And can drop the VerifyAPICredentials below since in this context GetCredentials will check them
thrasher-
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
David on Slack has been informing us of issues with the Backtester. This fix uses up-to-date credential checking functions instead of returning an error.
Before I could fix that I found Binance changed the json for SPOT/MARGIN execution limits to use [][]permissionSets
Upon fixing that I went to update our json mock data, and that showed that #1444 introduced a compatibility change with recording to the new path
I also came across duplicate errors right next to eachother and have addressed that
To test the Backtester
/backtester/config/strategyexamples/dca-candles-live.stratreal-orderstotruemaximum-totalto a tiny figure/backtesterexecutego run ./backtester/btcli/executego run . executestrategyfromfile -p="config/strategyexamples/dca-candles-live.strat"Fixes # (issue)
How has this been tested