Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/binance sub names #1508

Open
wants to merge 16 commits into
base: master
Choose a base branch
from

Conversation

Beadko
Copy link
Contributor

@Beadko Beadko commented Mar 20, 2024

PR Description

Binance does not allow the subscription on multiple channels, this change will compile 50 channels into one subscription.

Fixes # (issue)

Type of change

Please delete options that are not relevant and add an x in [] as item is complete.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How has this been tested

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration and
also consider improving test coverage whilst working on a certain feature or package.

  • go test ./... -race
  • golangci-lint run
  • TestSubscribe

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation and regenerated documentation via the documentation tool
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally and on Github Actions with my changes
  • Any dependent changes have been merged and published in downstream modules

gbjk and others added 16 commits February 23, 2024 15:03
If the exchange passed in already has a websocket, don't clobber it
instead of errChannelAlreadySubscribed
Given that some subscriptions have multiple pairs, support that as the
standard.
Except Kraken, which needs atomicity to not collide with upcoming work
Note: This is a naieve implementation because we want to rebase the
kraken websocket rewrite on top of this
We deliberately use Equal over Len to avoid spamming the contents of large Slices
@shazbert shazbert added the nomerge requires dependency This pull request is dependent on another, so it can't be merged until the dependent one is merged label Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
nomerge requires dependency This pull request is dependent on another, so it can't be merged until the dependent one is merged rebase/merge of master required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants