Websocket: Simplify the connectionMonitor

[Beadko]

PR Description

Currently, the WebSocket connectionMonitor is adding concurrency within the function. According to google styleguide, the caller should add the concurrency to the function.

Fixes # (issue)

Type of change

Please delete options that are not relevant and add an x in [] as item is complete.

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How has this been tested

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration and
also consider improving test coverage whilst working on a certain feature or package.

• go test ./... -race
• golangci-lint run
• TestConnectionMonitor

Checklist

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation and regenerated documentation via the documentation tool
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally and on Github Actions with my changes
• Any dependent changes have been merged and published in downstream modules

[codecov]

Codecov Report

Attention: Patch coverage is 66.66667% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 37.74%. Comparing base (d518993) to head (ba36511).
Report is 42 commits behind head on master.

❗ Current head ba36511 differs from pull request most recent head 0ce5d4b

Please upload reports for the commit 0ce5d4b to get more accurate results.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1502      +/-   ##
==========================================
- Coverage   37.75%   37.74%   -0.02%     
==========================================
  Files         411      411              
  Lines      147817   147804      -13     
==========================================
- Hits        55815    55794      -21     
- Misses      84218    84219       +1     
- Partials     7784     7791       +7     

Files	Coverage Δ
exchanges/stream/websocket.go	87.19% <66.66%> (+1.14%)	⬆️

... and 10 files with indirect coverage changes

[shazbert]

@Beadko Fine work. This is a much better approach. Just some nits and feedback.

[shazbert]

@Beadko Just waiting on these changes that was laid out from gk

[shazbert]

Thanks for the update, this is deadlocked by dataMonitor not being called in a go routine. Please update and retest. Once that is updated it then it looks good to go.

[shazbert]

Thanks for doing removing the deadlock. There some more things that need to be done and then it should be good to go. Well done.

There are some race issues in the ci build

[shazbert]

Thanks for the changes, there is a deadlock introduced in the tests. Then everything else looks good to go.

[shazbert]

@Beadko Nice clean! Thanks. tACK.