Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exchange/stream: toggle stream auto subscribe #1488

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

shazbert
Copy link
Collaborator

@shazbert shazbert commented Feb 29, 2024

PR Description

Fixes # (issue)

Type of change

Please delete options that are not relevant and add an x in [] as item is complete.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How has this been tested

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration and
also consider improving test coverage whilst working on a certain feature or package.

  • go test ./... -race
  • golangci-lint run
  • Test X

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation and regenerated documentation via the documentation tool
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally and on Github Actions with my changes
  • Any dependent changes have been merged and published in downstream modules

@shazbert shazbert added bug review me This pull request is ready for review high priority labels Feb 29, 2024
@shazbert shazbert requested a review from a team February 29, 2024 22:34
@shazbert shazbert self-assigned this Feb 29, 2024
Copy link

codecov bot commented Feb 29, 2024

Codecov Report

Attention: Patch coverage is 46.66667% with 16 lines in your changes are missing coverage. Please review.

Project coverage is 37.93%. Comparing base (1e95ae9) to head (3353d6d).

❗ Current head 3353d6d differs from pull request most recent head c236b25. Consider uploading reports for the commit c236b25 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1488      +/-   ##
==========================================
+ Coverage   37.91%   37.93%   +0.01%     
==========================================
  Files         411      411              
  Lines      147198   147204       +6     
==========================================
+ Hits        55817    55836      +19     
+ Misses      83588    83587       -1     
+ Partials     7793     7781      -12     
Files Coverage Δ
exchanges/exchange.go 80.33% <100.00%> (+0.88%) ⬆️
internal/testing/exchange/exchange.go 63.63% <50.00%> (-3.76%) ⬇️
engine/websocketroutine_manager.go 53.76% <0.00%> (+0.36%) ⬆️
exchanges/sharedtestvalues/customex.go 2.23% <0.00%> (ø)
exchanges/stream/websocket.go 85.74% <80.00%> (-0.32%) ⬇️
engine/rpcserver.go 42.11% <0.00%> (ø)

... and 30 files with indirect coverage changes

@gloriousCode
Copy link
Collaborator

Makes sense, but is there a particular exchange that this was affecting so that I may attempt to replicate your issue?

@shazbert
Copy link
Collaborator Author

shazbert commented Feb 29, 2024

Makes sense, but is there a particular exchange that this was affecting so that I may attempt to replicate your issue?

.\gocryptotrader --enableallpairs
[WARN] | WEBSOCKET | 01/03/2024 09:44:06 | Kucoin exchange backlog in websocket processing detected

For Kucoin and others with lots of subs.

@shazbert shazbert added low priority This enhancement or update will be implemented at a later date. and removed bug high priority labels Mar 4, 2024
@shazbert shazbert changed the title exchange/stream: toggle stream auto subscribe included bug fix exchange/stream: toggle stream auto subscribe Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
low priority This enhancement or update will be implemented at a later date. review me This pull request is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants