New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
exchange/stream: toggle stream auto subscribe #1488
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1488 +/- ##
==========================================
+ Coverage 37.91% 37.93% +0.01%
==========================================
Files 411 411
Lines 147198 147204 +6
==========================================
+ Hits 55817 55836 +19
+ Misses 83588 83587 -1
+ Partials 7793 7781 -12
|
Makes sense, but is there a particular exchange that this was affecting so that I may attempt to replicate your issue? |
.\gocryptotrader --enableallpairs For Kucoin and others with lots of subs. |
PR Description
In engine/websocketroutine_manager.go this swaps the connect and the receiver around so we can start a receiving service while the subscription routine is running. This reduces a blocking issue [BUG] and stops filling up the channel.Change already merged.Fixes # (issue)
Type of change
Please delete options that are not relevant and add an
x
in[]
as item is complete.How has this been tested
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration and
also consider improving test coverage whilst working on a certain feature or package.
Checklist