New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
exchanges: Add Futures WebSocket streaming and Spot WebSocket API #1446
Open
samuael
wants to merge
41
commits into
thrasher-corp:master
Choose a base branch
from
samuael:update_binance
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into update_binance
… into update_binance
… into update_binance
… into update_binance
… into update_binance
… into update_binance
… into update_binance
gloriousCode
added
review me
This pull request is ready for review
builds require fixing
labels
Jan 14, 2024
… into binance_futures_ws_update
… into binance_futures_ws_update
shazbert
requested changes
Feb 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
linter and spell checker needs to be fixed
… into binance_futures_ws_update
… into binance_futures_ws_update
samuael
force-pushed
the
update_binance
branch
from
February 21, 2024 21:18
0d74e3b
to
da09b8e
Compare
… into binance_futures_ws_update
… into binance_futures_ws_update
… into binance_futures_ws_update
… into binance_futures_ws_update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Selam team
This pull request introduces the WebSocket streaming functionalities for futures and API endpoint call methods through the Websocket stream for spot endpoints. The future web socket streaming adds support for USDTMarginedFutures and CoinMarginedFutures assets. It establishes connections and handles incoming stream data separately. Furthermore, the pull request extends support for SPOT WebSocket API and API endpoint calls via a distinct WebSocket stream. Ultimately, these WebSocket endpoint calls are seamlessly integrated with the wrapper functions.
Fixes # (issue)
Type of change
Please delete options that are not relevant and add an
x
in[]
as the item is complete.How has this been tested
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration and
also consider improving test coverage whilst working on a certain feature or package.
Checklist