Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update READLINE_ARCH #379

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

e-wang
Copy link

@e-wang e-wang commented Jul 12, 2020

Submitting here because the thoughtbot/homebrew-formulae README says to submit pull requests against the respective repos.

Calling MacOS.preferred_arch triggers the following warning during installation:

Warning: Calling MacOS.preferred_arch is deprecated! Use Hardware::CPU.arch (or ideally let the compiler handle it) instead.Please report this issue to the thoughtbot/formulae tap (not Homebrew/brew or Homebrew/core), or even better, submit a PR to fix it:  /usr/local/Homebrew/Library/Taps/thoughtbot/homebrew-formulae/Formula/gitsh.rb:47

I also updated the link to thoughtbot's Ruby style guide in CONTRIBUTING.

Calling MacOS.preferred_arch triggers the following warning during installation:

Warning: Calling MacOS.preferred_arch is deprecated! Use Hardware::CPU.arch (or
ideally let the compiler handle it) instead.
Copy link

@hound hound bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some files could not be reviewed due to errors:

Error: The `Layout/IndentArray` cop has been renamed to `Layout/IndentFirstAr...
Error: The `Layout/IndentArray` cop has been renamed to `Layout/IndentFirstArrayElement`.
(obsolete configuration found in .rubocop.yml, please update it)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant