Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce an object registry #371

Open
wants to merge 39 commits into
base: master
Choose a base branch
from
Open

Introduce an object registry #371

wants to merge 39 commits into from

Commits on Aug 3, 2019

  1. Introduce the object registry pattern. 

    Instead of passing around `env` absolutely everywhere, let's make it
available globally in a single, well-defined place.

We can't use a singleton for this, because we do sometimes need to create
different, modified environments, e.g. subshells.
    @georgebrock
    georgebrock committed Aug 3, 2019
    Configuration menu
    Copy the full SHA
    9b39bfd View commit details
    Browse the repository at this point in the history

  2. Use Registry.env in InputStrategies::Interactive

    @georgebrock
    georgebrock committed Aug 3, 2019
    Configuration menu
    Copy the full SHA
    609d7be View commit details
    Browse the repository at this point in the history

  3. Use Registry.env in History

    @georgebrock
    georgebrock committed Aug 3, 2019
    Configuration menu
    Copy the full SHA
    881b0b0 View commit details
    Browse the repository at this point in the history

  4. fixup! Use Registry.env in InputStrategies::Interactive

    @georgebrock
    georgebrock committed Aug 3, 2019
    Configuration menu
    Copy the full SHA
    273680b View commit details
    Browse the repository at this point in the history

  5. Use Registry.env in TabCompletion::Facade

    @georgebrock
    georgebrock committed Aug 3, 2019
    Configuration menu
    Copy the full SHA
    11ce21b View commit details
    Browse the repository at this point in the history

  6. Use Registry.env in TabCompletion::AutomatonFactory

    @georgebrock
    georgebrock committed Aug 3, 2019
    Configuration menu
    Copy the full SHA
    d1ffa83 View commit details
    Browse the repository at this point in the history

  7. Use Registry.env in TabCompletion::DSL

    @georgebrock
    georgebrock committed Aug 3, 2019
    Configuration menu
    Copy the full SHA
    ec297e7 View commit details
    Browse the repository at this point in the history

  8. Use Registry.env in TabCompletion::DSL::Parser

    @georgebrock
    georgebrock committed Aug 3, 2019
    Configuration menu
    Copy the full SHA
    053aaa9 View commit details
    Browse the repository at this point in the history

  9. Use Registry.env in TabCompletion::Matchers::*

    @georgebrock
    georgebrock committed Aug 3, 2019
    Configuration menu
    Copy the full SHA
    b19de01 View commit details
    Browse the repository at this point in the history

  10. Use Registry.env in TabCompletion::AliasExpander

    @georgebrock
    georgebrock committed Aug 3, 2019
    Configuration menu
    Copy the full SHA
    64fa06f View commit details
    Browse the repository at this point in the history

  11. Use Registry.env in TabCompletion::VariableCompleter

    @georgebrock
    georgebrock committed Aug 3, 2019
    Configuration menu
    Copy the full SHA
    db2932c View commit details
    Browse the repository at this point in the history

  12. Use Registry.env in PromptColor

    @georgebrock
    georgebrock committed Aug 3, 2019
    Configuration menu
    Copy the full SHA
    5188a88 View commit details
    Browse the repository at this point in the history

  13. Use Registry.env in Prompter

    @georgebrock
    georgebrock committed Aug 3, 2019
    Configuration menu
    Copy the full SHA
    9bf7794 View commit details
    Browse the repository at this point in the history

  14. Use Registry.env in InputStrategies::FileRunner

    @georgebrock
    georgebrock committed Aug 3, 2019
    Configuration menu
    Copy the full SHA
    3cf3c67 View commit details
    Browse the repository at this point in the history

  15. Meta-programming for registry client methods.

    @georgebrock
    georgebrock committed Aug 3, 2019
    Configuration menu
    Copy the full SHA
    d4794b8 View commit details
    Browse the repository at this point in the history

  16. Use Registry.env in GitRepository

    @georgebrock
    georgebrock committed Aug 3, 2019
    Configuration menu
    Copy the full SHA
    be425c3 View commit details
    Browse the repository at this point in the history

  17. Use Registry.env in GitCommandList

    @georgebrock
    georgebrock committed Aug 3, 2019
    Configuration menu
    Copy the full SHA
    f9a36ba View commit details
    Browse the repository at this point in the history

  18. Simplify: remove unused initialize argument.

    @georgebrock
    georgebrock committed Aug 3, 2019
    Configuration menu
    Copy the full SHA
    1601862 View commit details
    Browse the repository at this point in the history

  19. Add a GitRepository to the Registry.

    @georgebrock
    georgebrock committed Aug 3, 2019
    Configuration menu
    Copy the full SHA
    757c8ba View commit details
    Browse the repository at this point in the history

  20. Use Registry.repo in Environment

    @georgebrock
    georgebrock committed Aug 3, 2019
    Configuration menu
    Copy the full SHA
    cda7f59 View commit details
    Browse the repository at this point in the history

  21. Remove all the Env -> Repo delegates.

    @georgebrock
    georgebrock committed Aug 3, 2019
    Configuration menu
    Copy the full SHA
    49424d8 View commit details
    Browse the repository at this point in the history

  22. fixup! Use Registry.env in InputStrategies::Interactive

    @georgebrock
    georgebrock committed Aug 3, 2019
    Configuration menu
    Copy the full SHA
    d59529e View commit details
    Browse the repository at this point in the history

  23. Move line editor to registry.

    @georgebrock
    georgebrock committed Aug 3, 2019
    Configuration menu
    Copy the full SHA
    7aed129 View commit details
    Browse the repository at this point in the history

  24. Simplify CLI initializer.

    @georgebrock
    georgebrock committed Aug 3, 2019
    Configuration menu
    Copy the full SHA
    69c1aed View commit details
    Browse the repository at this point in the history

  25. Simplify Interpreter initializer.

    @georgebrock
    georgebrock committed Aug 3, 2019
    Configuration menu
    Copy the full SHA
    281a987 View commit details
    Browse the repository at this point in the history

  26. Simplify interactive input strategy initializer.

    @georgebrock
    georgebrock committed Aug 3, 2019
    Configuration menu
    Copy the full SHA
    22b620a View commit details
    Browse the repository at this point in the history

  27. Update bin/tcviz to use registry.

    @georgebrock
    georgebrock committed Aug 3, 2019
    Configuration menu
    Copy the full SHA
    37f499c View commit details
    Browse the repository at this point in the history

  28. Simplify Environment initializer.

    @georgebrock
    georgebrock committed Aug 3, 2019
    Configuration menu
    Copy the full SHA
    f5a1cc1 View commit details
    Browse the repository at this point in the history

  29. Use line editor from registry in tab completion.

    @georgebrock
    georgebrock committed Aug 3, 2019
    Configuration menu
    Copy the full SHA
    fe43ceb View commit details
    Browse the repository at this point in the history

  30. Remove unused initialize arg.

    @georgebrock
    georgebrock committed Aug 3, 2019
    Configuration menu
    Copy the full SHA
    9d4f645 View commit details
    Browse the repository at this point in the history

  31. fixup! Use line editor from registry in tab completion.

    @georgebrock
    georgebrock committed Aug 3, 2019
    Configuration menu
    Copy the full SHA
    7c20c56 View commit details
    Browse the repository at this point in the history

  32. Stop injecting constants into things.

    @georgebrock
    georgebrock committed Aug 3, 2019
    Configuration menu
    Copy the full SHA
    d1be651 View commit details
    Browse the repository at this point in the history

  33. Use keyword args.

    @georgebrock
    georgebrock committed Aug 3, 2019
    Configuration menu
    Copy the full SHA
    1c34f25 View commit details
    Browse the repository at this point in the history

  34. fixup! Use line editor from registry in tab completion.

    @georgebrock
    georgebrock committed Aug 3, 2019
    Configuration menu
    Copy the full SHA
    69cd772 View commit details
    Browse the repository at this point in the history

  35. More consistent registry use in specs.

    @georgebrock
    georgebrock committed Aug 3, 2019
    Configuration menu
    Copy the full SHA
    4cb690b View commit details
    Browse the repository at this point in the history

  36. DRY registry population code.

    @georgebrock
    georgebrock committed Aug 3, 2019
    Configuration menu
    Copy the full SHA
    8a77f2b View commit details
    Browse the repository at this point in the history

  37. Clean up registry interface.

    @georgebrock
    georgebrock committed Aug 3, 2019
    Configuration menu
    Copy the full SHA
    a2d60a4 View commit details
    Browse the repository at this point in the history

  38. fixup! Simplify interactive input strategy initializer.

    @georgebrock
    georgebrock committed Aug 3, 2019
    Configuration menu
    Copy the full SHA
    910e689 View commit details
    Browse the repository at this point in the history

  39. fixup! Stop injecting constants into things.

    @georgebrock
    georgebrock committed Aug 3, 2019
    Configuration menu
    Copy the full SHA
    80cca72 View commit details
    Browse the repository at this point in the history