Add a $branch variable to tab completion #353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A $revision is more appropriate here than $anything.
The Gitsh::TabCompletion::RevisionMatcher class was ignoring some patterns that are followed by other matcher classes. This commit makes it more consistent with the others.
houndci-bot
reviewed
Feb 21, 2019
houndci-bot
reviewed
Feb 21, 2019
|
Checks off one of the items on #314 |
The $branch matchers produces branch names, and can be used in places where the $revision matcher is too permissive, e.g. `branch -d` only accepts a branch name, not a tag name etc.
georgebrock
force-pushed
the
tab-completion-matchers
branch
from
a8d23f3
to
0e118a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #352
The tab completion DSL had a
$revisionvariable which produces branch names, tag names, etc. In some contexts it's too general, e.g.branch -Daccepts a branch name but not a tag. In those contexts we were using$anythingto avoid producing invalid tab completion options.This PR introduces a more specific
$branchvariable that can be used when we want to only tab complete branch names.