Only run this workflow if the README has been updated #1635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefannibrasil
force-pushed
the
sb-dynamic-readme-updates
branch
from
e1fa128
to
391c47c
Compare
|
Thanks for your patience, @mike-burns this is the follow up of #1630 In summary, some repos have branch protection rules that conflicted with the workflow pushing changes directly to the main branch. In the templates repo, the workflow has been updated to open a PR with the README updates. So it will follow the regular flow of PR -> merge. Thank you! |
stefannibrasil
commented
Apr 12, 2024
| @@ -82,6 +82,7 @@ software, and may be redistributed under the terms specified in the | |||
| [LICENSE]: https://github.com/thoughtbot/factory_bot/blob/main/LICENSE | |||
|
|
|||
| <!-- START /templates/footer.md --> | |||
|
|
|||
There was a problem hiding this comment.
With this change, the workflow will generate an automatic PR with the generated content.
mike-burns
approved these changes
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the templates repo, the update-templates workflow has been updated to accommodate repositories that have main branch rules (like factory_bot). To generate the README dynamically, you’ll need to merge a PR with the README changes. That will trigger the GitHub workflow
The PR won’t be generated if the footer content does not have any differences from the template. The PR will only be opened if there’s an update to the footer snippet.
In this PR, we are limiting this workflow to be triggered only when README changes have been merged to main (where the snippet lives).