lottie: replace cubics with lines where possible #2263
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hermet
added
optimization
|
@mgrudzinska Does this necessary for rounded corner? I've assumed it would but the performance enhancement for Curve 2 Line is not clear yet. Let's carefully review it before confirming. |
mgrudzinska
force-pushed
the
mira/lineTo
branch
3 times, most recently
from
383b50a
to
a74c729
Compare
When the loaded control points are zero (in and out), there is no need to apply bezier curves - they can be replaced with straight lines.
@hermet no it's not necessary for rounded corner. I just wanted to point it out that this is an easier solution then using |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the loaded control points are zero (in and out), there is no need to apply bezier curves - they can be replaced with straight lines.