New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
draft: experimental code formatting #2199
base: main
Are you sure you want to change the base?
Conversation
@hermet Do you think this method is acceptable? |
@RuiwenTang Firstly, I'm welcome to this. Here are two major points we need to make a consensus:
|
I think it all depends on you. We can discuss the details of coding style together, clang-format in this PR is for demonstration only.
|
Firstly, many contributors face the same challenges when they contribute to an unfamiliar project, often making similar mistakes. This is not an issue unique to ThorVG. Rather, I would like to emphasize that while coding conventions for developers are a minor issue, integration issues with ThorVG will be more significant. Therefore, I am placing a bet on this for the 1.0 release. Otherwise, integrating it with large systems like Godot, LVGL, and Tizen could pose major challenges. Perhaps we could consider an auto-formatting script that aligns with the current ThorVG style. People could simply write the code first and run the script afterward. It's easy, and everyone will be happy. |
As mentioned in #1519
We need an automated code formatting tool and consistent code style
This PR shows how to use clang-format to define a coding style and use
.git-blame-ignore-revs
to ignore the format commit from normal gitblame.github can apply this ignore list automatically. For local repository, need run the following command: