fix: corrected check on missing super admin value, closes #2391

thorsten · Mar 27, 2023 · fd2cda1 · fd2cda1
1 parent 5d2a071
commit fd2cda1
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/phpmyfaq/admin/ajax.user.php b/phpmyfaq/admin/ajax.user.php
@@ -123,7 +123,7 @@
             $automaticPassword = Filter::filterVar($postData['automaticPassword'], FILTER_VALIDATE_BOOLEAN);
             $userPassword = Filter::filterVar($postData['password'], FILTER_UNSAFE_RAW);
             $userPasswordConfirm = Filter::filterVar($postData['passwordConfirm'], FILTER_UNSAFE_RAW);
-            $userIsSuperAdmin = Filter::filterVar($postData['isSuperAdmin'], FILTER_VALIDATE_BOOLEAN);
+            $userIsSuperAdmin = Filter::filterVar($postData['isSuperAdmin'] ?? false, FILTER_VALIDATE_BOOLEAN);
 
             $newUser = new User($faqConfig);
 
@@ -153,7 +153,7 @@
                 } else {
                     $newUser->userdata->set(['display_name', 'email', 'is_visible'], [$userRealName, $userEmail, 0]);
                     $newUser->setStatus('active');
-                    $newUser->setSuperAdmin(!is_null($userIsSuperAdmin));
+                    $newUser->setSuperAdmin($userIsSuperAdmin);
                     $mailHelper = new MailHelper($faqConfig);
                     try {
                         $mailHelper->sendMailToNewUser($newUser, $userPassword);