Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web font path resolution #1281

Merged
merged 38 commits into from
Oct 17, 2023
Merged

Conversation

rawnsley
Copy link
Contributor

Fixes #1280

XhmikosR and others added 30 commits January 22, 2021 08:52
* autoprefixer  ^10.1.0  →  ^10.2.3
* grunt-html    ^14.2.0  →  ^14.2.1
* postcss        ^8.2.0  →   ^8.2.4
* stylelint     ^13.8.0  →  ^13.9.0
* remove `CI: true` env var since it's already set by the runner
* update to `actions/setup-node@v2`
* lowercase `runner.os`
* docs
* release
@thomaspark
Copy link
Owner

Hey @rawnsley, with these changes, this happens for me when $web-font-path is set to false.

Warning: Ignoring local @import of "dist/sketchy/false" as resource is missing.
>> No files created.

However this works for me:

@if $web-font-path {
  @import url("#{$web-font-path}");
}

Does it fix your parse issue as well?

@rawnsley
Copy link
Contributor Author

@thomaspark you are quite right! It was wrong to resolve it in the @if statement, but setting it to an empty string had the same effect (but messier) because the import was ignored. It looks like SASS is stricter on truthiness than JS and you must use false or null. Two wrongs combined to make something not quite right.

@thomaspark thomaspark changed the base branch from master to v5 October 17, 2023 13:30
@thomaspark thomaspark merged commit c74d13f into thomaspark:v5 Oct 17, 2023
4 checks passed
@thomaspark
Copy link
Owner

This looks good to go. Thanks @rawnsley.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Web font themes not working
3 participants