Hide books section on home page since books are empty #781
Conversation
✅ Deploy Preview for node-framework-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for framework-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for qwik-framework-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for system-framework-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for react-framework-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for vue-framework-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for svelte-framework-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for graphql-framework-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for deno-framework-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for solid-framework-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for angular-framework-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| { | ||
| title: 'Rodney Lab', | ||
| author: 'Rodney', | ||
| description: | ||
| 'Hello and welcome! I’m Rodney, a web developer based in the UK 🇬🇧 and am available for consultancy work.', | ||
| image: | ||
| 'https://rodneylab.com/assets/rodney-johnson-about-rodneylab-1350x1350.208d1490.avif', | ||
| href: 'https://rodneylab.com/tags/sveltekit/', | ||
| tags: [], | ||
| }, |
There was a problem hiding this comment.
Curious, why was this one removed? At first glance, it does look like a bunch of SvelteKit blogs.
There was a problem hiding this comment.
This was a duplicate.
So I had to remove it.
| "Matija from 🇭🇷 Croatia and he's infinitely curious at how things work but he's mostly passionate about ☕ JavaScript and 🎨 UI/UX design.", | ||
| "Matija from Croatia and he's infinitely curious at how things work but he's mostly passionate about JavaScript and UI/UX design.", |
There was a problem hiding this comment.
Wondering why emoji are being removed. Rendering issues? I know flags sometimes don't render right depending on the OS and browser—had that problem plenty of times on Windows machines. Not sure if that's still the case, or the reason for removing them in this PR.
There was a problem hiding this comment.
I removed them due to rendering issues.
They were not rendering correctly on my Mac and I perceive some users might have the same issue.
I don't think it adds enough value to decide to accommodate it, so I removed it.
| { | ||
| name: 'Svelte Summit', | ||
| description: 'A meetup dedicated to the latest release of Svelte', | ||
| image: 'https://sveltesociety.dev/images/logo.svg', | ||
| type: 'Live Events', | ||
| href: 'https://beta.guild.host/svelte-society-london/events', | ||
| tags: ['conferences'], | ||
| }, |
There was a problem hiding this comment.
Looks outdated as a conference, but appears to be a still-active community. Why remove it? Just needs some updating to make it a bit more evergreen.
There was a problem hiding this comment.
This was a duplicate and the link is not the correct link for Svelte Summit.
There is another entry that has the correct info.
|
Hi @vyktoremario. 👋 Your PR has been approved and merged. 🎉 Thank you for your continued contributions to framework.dev. ❤️ Keep up the great work! |
Type of change
Summary of change
Hide books section on home page since books are empty
Checklist
given the go-ahead to work on it in the relevant issue discussion
packages/system/src/componentswith a.stories.tsxfile thatadequately renders possible variations of each component.