Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New styles for links to non-NPM packages #527

Merged
merged 2 commits into from
Oct 24, 2023
Merged

New styles for links to non-NPM packages #527

merged 2 commits into from
Oct 24, 2023

Conversation

tvanantwerp
Copy link
Contributor

@tvanantwerp tvanantwerp commented Dec 3, 2022 •
edited

Type of change

  • Content addition
  • Bug fix
  • Behavior change

Summary of change

Where a package isn't hosted on NPM, the existing fallback is an unstyled link. It doesn't fit with the styles of any of the other badges in library cards and its purpose is visually confusing. This PR implements a new fallback with styles that better match existing badges.

image

Checklist

  • The changes follow the contributing guidelines
  • I have verified the fix works and introduces no further errors
  • I have confirmed with a maintainer that this change is desired and been
    given the go-ahead to work on it in the relevant issue discussion
  • The changes follow the contributing guidelines
  • I have verified the change and the rest of the site works as expected
  • If the change introduces new components, these have been added to
    packages/system/src/components with a .stories.tsx file that
    adequately renders possible variations of each component.

@tvanantwerp tvanantwerp self-assigned this Dec 3, 2022
@tvanantwerp tvanantwerp added enhancement New feature or request refinement The issue needs further clarification and definition labels Dec 3, 2022
@netlify
Copy link

netlify bot commented Dec 3, 2022 •
edited

✅ Deploy Preview for node-framework-dev ready!

Name Link
🔨 Latest commit 9e67667
🔍 Latest deploy log https://app.netlify.com/sites/node-framework-dev/deploys/640f7077a32ebd0008ddabf9
😎 Deploy Preview https://deploy-preview-527--node-framework-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Dec 3, 2022 •
edited

✅ Deploy Preview for framework-dev ready!

Name Link
🔨 Latest commit 9e67667
🔍 Latest deploy log https://app.netlify.com/sites/framework-dev/deploys/640f7077d5c2db00083f4999
😎 Deploy Preview https://deploy-preview-527--framework-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Dec 3, 2022 •
edited

✅ Deploy Preview for qwik-framework-dev ready!

Name Link
🔨 Latest commit 9e67667
🔍 Latest deploy log https://app.netlify.com/sites/qwik-framework-dev/deploys/640f7077a41b5c00077b464a
😎 Deploy Preview https://deploy-preview-527--qwik-framework-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Dec 3, 2022 •
edited

✅ Deploy Preview for system-framework-dev ready!

Name Link
🔨 Latest commit 9e67667
🔍 Latest deploy log https://app.netlify.com/sites/system-framework-dev/deploys/640f707716d81e000781fa1d
😎 Deploy Preview https://deploy-preview-527--system-framework-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Dec 3, 2022 •
edited

✅ Deploy Preview for vue-framework-dev ready!

Name Link
🔨 Latest commit 9e67667
🔍 Latest deploy log https://app.netlify.com/sites/vue-framework-dev/deploys/640f70774074070008a6e66b
😎 Deploy Preview https://deploy-preview-527--vue-framework-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Dec 3, 2022 •
edited

✅ Deploy Preview for svelte-framework-dev ready!

Name Link
🔨 Latest commit 9e67667
🔍 Latest deploy log https://app.netlify.com/sites/svelte-framework-dev/deploys/640f70777e3b5f000886838f
😎 Deploy Preview https://deploy-preview-527--svelte-framework-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Dec 3, 2022 •
edited

✅ Deploy Preview for solid-framework-dev ready!

Name Link
🔨 Latest commit 9e67667
🔍 Latest deploy log https://app.netlify.com/sites/solid-framework-dev/deploys/640f70773cd90b0008caeaf7
😎 Deploy Preview https://deploy-preview-527--solid-framework-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Dec 3, 2022 •
edited

✅ Deploy Preview for angular-framework-dev ready!

Name Link
🔨 Latest commit 9e67667
🔍 Latest deploy log https://app.netlify.com/sites/angular-framework-dev/deploys/640f70778ac07e0008094d97
😎 Deploy Preview https://deploy-preview-527--angular-framework-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Dec 3, 2022 •
edited

✅ Deploy Preview for graphql-framework-dev ready!

Name Link
🔨 Latest commit 9e67667
🔍 Latest deploy log https://app.netlify.com/sites/graphql-framework-dev/deploys/640f70773751e9000845079b
😎 Deploy Preview https://deploy-preview-527--graphql-framework-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Dec 3, 2022 •
edited

✅ Deploy Preview for react-framework-dev ready!

Name Link
🔨 Latest commit 9e67667
🔍 Latest deploy log https://app.netlify.com/sites/react-framework-dev/deploys/640f7077c51df90008da3b1b
😎 Deploy Preview https://deploy-preview-527--react-framework-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@aws-amplify-us-west-2
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-527.d27jqwpr7xbhbg.amplifyapp.com

@aws-amplify-us-west-2
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-527.d7tvjh0fjnmfb.amplifyapp.com

@aws-amplify-us-west-2
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-527.d2p90ebpjki1x1.amplifyapp.com

@aws-amplify-us-west-2
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-527.d3jumo4flgkgg2.amplifyapp.com

@aws-amplify-us-west-2
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-527.dyubha3epirtj.amplifyapp.com

@danecando danecando force-pushed the fix/alternative-packages-badges branch from 0be5701 to 9e67667 Compare March 13, 2023 18:50
@sonarcloud
Copy link

sonarcloud bot commented Mar 13, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
1.5% 1.5% Duplication

@netlify
Copy link

netlify bot commented Mar 13, 2023 •
edited

✅ Deploy Preview for deno-framework-dev ready!

Name Link
🔨 Latest commit 9e67667
🔍 Latest deploy log https://app.netlify.com/sites/deno-framework-dev/deploys/640f7077b307450008176958
😎 Deploy Preview https://deploy-preview-527--deno-framework-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@tvanantwerp tvanantwerp merged commit 0883e12 into main Oct 24, 2023
@tvanantwerp tvanantwerp deleted the fix/alternative-packages-badges branch October 24, 2023 16:05
@thisdot-bot
Copy link

Hi @tvanantwerp. 👋

Your PR has been approved and merged. 🎉

Thank you for your continued contributions to framework.dev. ❤️

Keep up the great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vyktoremario vyktoremario vyktoremario approved these changes

Assignees

@tvanantwerp tvanantwerp

Labels
enhancement New feature or request refinement The issue needs further clarification and definition
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tvanantwerp @thisdot-bot @vyktoremario