fix env var inclusion in ga tag

thisdot · Apr 5, 2024 · 4701c1c · 4701c1c
1 parent adcd645
commit 4701c1c
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/packages/landing-site/src/pages/index.astro b/packages/landing-site/src/pages/index.astro
@@ -12,6 +12,7 @@ import { landingBody } from '@framework/system/src/styles/layouts.css'
 import { SocialMetaTags } from '../../../site/src/components/social-meta-tags'
 
 const contributorsData = await getContributorsData()
+const GA_TAG_ID = import.meta.env.VITE_GOOGLE_ANALYTICS
 ---
 
 <!doctype html>
@@ -37,11 +38,11 @@ const contributorsData = await getContributorsData()
 					async
 					src={`https://www.googletagmanager.com/gtag/js?id=${import.meta.env.VITE_GOOGLE_ANALYTICS}`}>
 				</script>
-				<script is:inline>
+				<script is:inline define:vars={{ GA_TAG_ID }}>
 					window.dataLayer = window.dataLayer || [];
 					function gtag(){dataLayer.push(arguments);}
 					gtag('js', new Date());
-					gtag('config', '${import.meta.env.VITE_GOOGLE_ANALYTICS}');
+					gtag('config', GA_TAG_ID);
 				</script>
 			)
 		}

diff --git a/packages/site/src/layouts/base.astro b/packages/site/src/layouts/base.astro
@@ -21,6 +21,8 @@ const navData = searchData.map((o) => pick(o, ['name', 'subCategories']))
 const themeClass = themes[
 	`${import.meta.env.VITE_FRAMEWORK}Theme` as keyof typeof themes
 ] as string
+
+const GA_TAG_ID = import.meta.env.VITE_GOOGLE_ANALYTICS
 ---
 
 <!doctype html>
@@ -53,11 +55,11 @@ const themeClass = themes[
 					async
 					src={`https://www.googletagmanager.com/gtag/js?id=${import.meta.env.VITE_GOOGLE_ANALYTICS}`}>
 				</script>
-				<script is:inline>
+				<script is:inline define:vars={{ GA_TAG_ID }}>
 					window.dataLayer = window.dataLayer || [];
 					function gtag(){dataLayer.push(arguments);}
 					gtag('js', new Date());
-					gtag('config', '${import.meta.env.VITE_GOOGLE_ANALYTICS}');
+					gtag('config', GA_TAG_ID);
 				</script>
 			)
 		}