-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pluggable repository layer #39
Add pluggable repository layer #39
Conversation
6156b20
to
f7ddf05
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all looks quite good so far. Just worth mentioning that along with the observability
table there is also a jobs
table.
@hiepd the build is failing because |
f7ddf05
to
7f1cf53
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's some Github Actions failing on this, but I'm not too worried about this right now. There's likely some logic here and there that needs some changes.
I see you specify the datastore when you run the odin-engine binary. It could potentially be better for the user to define their datastore details in https://github.com/theycallmemac/odin/blob/master/odin-engine/config/odin-config.yml
.
7f1cf53
to
183ded2
Compare
183ded2
to
4f715f6
Compare
Thanks @theycallmemac . I have changed the code to use I think we can also figure out how to run migration for relational storage in the future as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay this is looking good as far as the changes are concerned. I'll take a look at the failing build and see if I can get it fixed!
@hiepd Having a quick look. The dependency step is breaking because /pkg/repository doesn't exist in the master branch, once this is merged it should fix it. |
8195778
into
theycallmemac:v2.0.0/pluggable-repository-layer
Repository consists of
Part of #34
Usage:
With odin-engine