Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implemented some interesting user suggestions #202

Merged
merged 11 commits into from
May 16, 2024
Merged

Implemented some interesting user suggestions #202

merged 11 commits into from
May 16, 2024

Conversation

alexanderkind
Copy link
Contributor

@alexanderkind alexanderkind commented Mar 16, 2023 •
edited

Implemented some interesting user suggestions:

  1. Rounding data module and eye corners QR Square rounded #192
  2. Rounding data module outside corners
  3. Background shape behind embedded image with rounding corners (EmbeddedImageShape)
  4. Adjusting the cutout of an embedded image Feature Request: cutout for embedded image #190
  5. Gradient for all (QrDataModuleShape, QrEyeShape, EmbeddedImageShape) gradient #143

vanyasem
vanyasem reviewed Apr 30, 2023
View reviewed changes
lib/src/types.dart Outdated Show resolved Hide resolved
vanyasem
vanyasem reviewed Apr 30, 2023
View reviewed changes
lib/src/qr_painter.dart Outdated Show resolved Hide resolved
@alexanderkind
added function of rounding outside corners
93feb06 
made some changes to the code
@vanyasem
Copy link
Contributor

vanyasem commented May 1, 2023

thank you for addressing the review so quickly!

@alexanderkind alexanderkind changed the title Add BorderRadius for EyeStyle and DataModuleStyle, gradient, cutout of image embedded, background shape embedded image Implemented some interesting user suggestions May 17, 2023
@razfazz
Copy link

razfazz commented May 30, 2023

wow very nice! thank you

@alexanderkind
Merge branch 'master' of https://github.com/theyakka/qr.flutter
8a64f0c 
� Conflicts:
�	example/android/app/build.gradle
�	example/android/build.gradle
�	example/lib/main_screen.dart
�	lib/src/qr_image_view.dart
�	lib/src/qr_painter.dart
�	lib/src/types.dart
@alexanderkind
Change README.md
5ca1a5f
@mminhlequang
Copy link

up

1 similar comment
@2Math0
Copy link

2Math0 commented Oct 12, 2023

up

@benjdero
Copy link

@vanyasem What's preventing this from being merged? The proper image cutout alone makes the result look much more professional.

@vanyasem
Copy link
Contributor

@benjdero the fact that I am just a contributor, and not a project maintainer. I do not have write access to this repository, and thus I cannot merge this PR :)
You need to contact the maintainers of this repo by email: hello@theyakka.com

@martipello
Copy link

LGTM!!!

@Hilbert2048
Copy link

@vanyasem why this update is still not merged?

@vanyasem
Copy link
Contributor

@Hilbert2048 because I am just a random contributor, and not a maintainer of this project. I do not have write access to this repository, and thus I cannot merge this PR :)
You need to contact the actual maintainers of this repo by email: hello@theyakka.com

@Hilbert2048
Copy link

I think @lukef might have the write permission, would you please have a look at this pull request?

@lukef lukef merged commit 4fb4c4d into theyakka:master May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vanyasem vanyasem vanyasem left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@alexanderkind @vanyasem @razfazz @mminhlequang @2Math0 @benjdero @martipello @Hilbert2048 @lukef