#104: Fixed the padding #144
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lukef any idea how we can get this merged? |
|
We are using this branch in production for over 7 months. Our app has 7 million installs. And we never had one complaint about a qr code that could not be scanned correctly. So I do think this can be merged and released |
|
Yep. This will be fixed in 5.0. I rewrote part of that code (for various reasons). Keeping this open as a reminder but you can check the (sometimes broken) work in progress on the wip-50 branch. Heads up, 5.0 will break compatibility. Feedback welcome. |
|
Specific fixes are:
|
|
Alright thanks already. We will migrate when this pull request in closed (meaning it is released) |
|
@lukef any progress |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #104