Fix mixed up control messages #144
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In ModalBar.cpp the control messages for 'Stick direct mix' and 'Vibrato amplitude' have been mixed up. This also concerns some documentation but the description on https://ccrma.stanford.edu/software/stk/classstk_1_1ModalBar.html, which is generated from the source, is correct.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In ModalBar.cpp the control messages for 'Stick direct mix' and 'Vibrato amplitude' have been mixed up. This also concerns some documentation but the description on https://ccrma.stanford.edu/software/stk/classstk_1_1ModalBar.html, which is generated from the source, is correct. The following changes make modalbar control changes correspond to that documentation.
This is obviously disruptive downstream since existing code using 'Vibrato gain' or 'Stick mix' would have had to bee sending the wrong signal, as is the case in lmms.
Fixes #143