Move include(CTest) to inside testing guard #413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The RTAUDIO_BUILD_TESTING variable stops the testing target ejection but still does an include(CTest) which injects the standard CTest macros from enable_testing(). In rtmidi you include(CTest) inside the guard but in rtaudio you do not; as such using the cmake in a non-ctest project ejects multiple targets. For now you can get around this with BUILD_TESTING globally off but that means you can't activate your own ctests optionally. So move the include(CTEst) to be in the same spot as it is in rtmidi. Thanks for great software!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The RTAUDIO_BUILD_TESTING variable stops the testing target ejection but still does an include(CTest) which injects the standard CTest macros from enable_testing(). In rtmidi you include(CTest) inside the guard but in rtaudio you do not; as such using the cmake in a non-ctest project ejects multiple targets.
For now you can get around this with BUILD_TESTING globally off but that means you can't activate your own ctests optionally.
So move the include(CTEst) to be in the same spot as it is in rtmidi.
Thanks for great software!