Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix linking error to pthreads with MinGW #408

Merged
merged 1 commit into from Aug 8, 2023
Merged

Fix linking error to pthreads with MinGW #408

merged 1 commit into from Aug 8, 2023

Conversation

Smail
Copy link
Contributor

@Smail Smail commented Aug 8, 2023 •
edited

Closes #407

@Smail
Copy link
Contributor Author

Smail commented Aug 8, 2023

pthread functions are used in rtaudio.cpp since 6.0.0 with macros called MUTEX_LOCK, etc., depending on whether the application is compiled with MSVC or not. The problem here is, that when compiled with MinGW, the MSVC macro is undefined and hence it's compiled with pthreads, but pthreads is not added as linking dependency in CMakeLists.txt.

@garyscavone garyscavone merged commit 13a5839 into thestk:master Aug 8, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Undefined Reference to pthread_mutex_* in MinGW since 6.0.0
2 participants
@Smail @garyscavone