Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AVX optimizations for the convertBuffer function #241

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

eloi-loomai
Copy link

No description provided.

@garyscavone
Copy link
Contributor

Why was this closed?

@eloi-loomai eloi-loomai reopened this Apr 13, 2020
@radarsat1
Copy link
Contributor

This is great, only it makes me wish we had unit tests!
@eloi-loomai have you tried to see if autovectorization can get to the same result? I find it much cleaner and less error prone than manual intrinsics when you can get it to work. Have you done performance testing?

@garyscavone
Copy link
Contributor

I agree that these changes would make the code harder to maintain and update in the future. I'm inclined to close this PR without merging it, unless someone can convince me otherwise in the next few days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants