Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfixes #105

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

bunker-bunk567
Copy link

see commit message

…rough x=0,y=0)

change (net <net> "name") to (net <net>) (net_name "name")
more concise code in the via section
copy net for SUBPOLYINDEX region from master Polygon
use heuristic to determine which polygons are apparently
overidden by associated regions, or else kicad pours too much.
this seems to be a kicad limitation, but manual fix is very easy.

bugfixing done working this board:

https://shop.trenz-electronic.de/trenzdownloads/Trenz_Electronic/Modules_and_Module_Carriers/4x5/4x5_Carriers/TE0706/REV03/HW_Design/AP-TE0706-03.zip
@bunker-bunk567
Copy link
Author

bunker-bunk567 commented Feb 2, 2021

btw, i started learning PCB design a couple of weeks ago, i don't own altium. so don't see this as professional advice. the subpolyindex scheme is not optimal, but leaving it out would also not be. in both cases, manual fixes are likely necessary (just changing nets, no drawing). which can be expected from users of this tool of course.

to do it right, geometric analysis must associate a subpolyindex region with a pour polygon, the right one (this should be pretty easy, the idea is that there would be substantial vertex and edge overlap between the 2).

i will send a proper fix soon for this.

@bunker-bunk567
Copy link
Author

bunker-bunk567 commented Feb 2, 2021

also note that this patch inverts the mapping of pour index and zone priority.

100 - pour_index = kicad_priority

seems to be the right choice to me, but review that please

@bunker-bunk567
Copy link
Author

@thesourcerer8 i am sure kicad-devel would love to hear about it. Their altium importer does not handle subpolyindex and creating these intricate polygon shapes by hand is laborious.

@thesourcerer8
Copy link
Owner

Long ago, when I saw the first few files, I thought that pour_index is between 0 and 100, but then suddenly I got files with a pour_index far outside that range, so I did didnt had a good idea anymore how to properly handle them, and what their meaning really is.
I think I will have to revisit my file-collection to see which pour_index values we actually have now. Perhaps we should develop a small tool that can work through many .pcbdoc files and extracts all pour_index values? I would like to avoid regressions there ...

@bunker-bunk567
Copy link
Author

just leave the pourindex conversion out.

But it seems obvious to me that 0 has the highest priority for altium for a couple of reasons.

with kicad we know that higher numeric value has higher priority.

I don't have altium so i cannot confirm it.

If you see values above 100, that probably means altium allows a bigger range of values and 100 is the upper limit as per convention only.

* get board outline and coordinate origin from the pcbdoc

* default to no thermal reliefs for now

* use kicad6 island_removal

* use some regions that have seemingly illegal length fields
@thesourcerer8
Copy link
Owner

Can anyone with an Altium license check the meaning of positive and negative priorities please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants