Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement stack unwinding for cancelled tasks #769

Open
wants to merge 16 commits into
base: theseus_main
Choose a base branch
from
Open

Implement stack unwinding for cancelled tasks #769

wants to merge 16 commits into from

Conversation

tsoutsman
Copy link
Member

@tsoutsman tsoutsman commented Dec 25, 2022 •
edited

Depends on #766.

Closes #770.

Signed-off-by: Klim Tsoutsman klim@tsoutsman.com

@tsoutsman
Add task cancellation test
8bd4630 
It doesn't currently pass, but should in the near future.

Signed-off-by: Klim Tsoutsman <klim@tsoutsman.com>
@tsoutsman
Modify test_task_cancel to generate LSDA for guard_holder
a6e4596 
Signed-off-by: Klim Tsoutsman <klim@tsoutsman.com>
@tsoutsman tsoutsman marked this pull request as draft December 25, 2022 12:54
@tsoutsman
Working
6601443 
Signed-off-by: Klim Tsoutsman <klim@tsoutsman.com>
@tsoutsman
Modify test_task_cancel to generate LSDA for guard_holder
4edd99f 
Signed-off-by: Klim Tsoutsman <klim@tsoutsman.com>
@tsoutsman
Move can_unwind into unwind
cd80e0a 
Signed-off-by: Klim Tsoutsman <klim@tsoutsman.com>
@tsoutsman
Update docs
074688b 
Signed-off-by: Klim Tsoutsman <klim@tsoutsman.com>
@tsoutsman
Merge branch 'test-task-cancellation' into task-cancel
08d0140 
Signed-off-by: Klim Tsoutsman <klim@tsoutsman.com>
@tsoutsman
Change second unwind condition to require an associated landing pad
3e5ffce 
Signed-off-by: Klim Tsoutsman <klim@tsoutsman.com>
@tsoutsman
Remove unnecessary task_cancel dependencies
432cc1d 
Signed-off-by: Klim Tsoutsman <klim@tsoutsman.com>
@tsoutsman
Add documentation for trap flag in interrupts
5b86930 
Signed-off-by: Klim Tsoutsman <klim@tsoutsman.com>
@tsoutsman
Better document test_task_cancel
1a6e44e 
Signed-off-by: Klim Tsoutsman <klim@tsoutsman.com>
@tsoutsman
Copy link
Member Author

I've manually tested all three scenarios in test_task_cancel by rerunning test_task_cancel and checking log outputs.

Not sure about the naming of start_remote_unwinding.

@tsoutsman tsoutsman marked this pull request as ready for review December 26, 2022 04:20
@tsoutsman
Copy link
Member Author

Also, as discussed before, this won't be able to unwind all tasks. Should cancel_task spawn another task that, after some timeout period (e.g. 5 seconds), checks if the original task has been unwound and, if not, aborts it?

@tsoutsman
Merge branch 'theseus_main' into task-cancel
8c74210 
Signed-off-by: Klimenty Tsoutsman <klim@tsoutsman.com>
@tsoutsman
Merge branch 'theseus_main' into task-cancel
0b77def
@tsoutsman
Satisfy clippy
adb3b0e 
Signed-off-by: Klimenty Tsoutsman <klim@tsoutsman.com>
@tsoutsman
Merge branch 'theseus_main' into task-cancel
9849e9c
@tsoutsman
Clippy
bda973c 
Signed-off-by: Klimenty Tsoutsman <klim@tsoutsman.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinaboos kevinaboos Awaiting requested review from kevinaboos

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unwind cancelled tasks
1 participant
@tsoutsman