Add possibility to have git repo root dir and gulpfile in different folders #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t dir not in the same folder Require process.env.GITDIR variable to have path to .git parent folder. Refer therealklanni#41
Needed to prevent npm from complaining `No version provided` when installing package by url.
| var stripBom = require('strip-bom'); | ||
| var map = require('map-stream'); | ||
| var hookArgs = process.env.HOOK_ARGS ? process.env.HOOK_ARGS.split('\u263a') : []; | ||
|
|
||
| function getIndexed() { | ||
| return _.compact(execSync('git diff --cached --name-only --diff-filter=ACM', { | ||
| var gitParentDir = process.env.GITDIR || process.cwd(); |
There was a problem hiding this comment.
Let's avoid using env vars to control this. See this comment.
In summary, I'd rather see this done using a package that can automatically determine the project/app root.
|
Thanks very much for your contribution. There are a couple things I would like changed before I can accept this PR, however. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refer to this issue
When .git and gulpfile are in different folders
guppy.srcandguppy.streamreturn empty arrays of related files.Fixed.