Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed 'disable_send_mail' to 'disable_send_email' #25

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Swahjak
Copy link
Contributor

@Swahjak Swahjak commented Apr 24, 2017

Changed 'disable_send_mail' to 'disable_send_email' to comply to the official MultiSafepay API documentation (https://www.multisafepay.com/documentation/doc/API-Reference/).

I haven't been able to test this since we were planning on using this with bank transfer but it hasn't been implemented (yet) for bank transfers (we've got an pending request on this at multisafepay). But as it's documented in the official API documentation I think we can presume it should be 'disable_send_email'.

@delatbabel
Copy link
Contributor

OK thanks for the contribution but I'd like to hear that it works at least in a sandbox/test environment before merging please.

@Swahjak
Copy link
Contributor Author

Swahjak commented May 12, 2017

The thing is, it is not working either way at the moment. The API documentation describes the parameter, but it isn't actually functioning whether you use 'disable_send_mail' or 'disable_send_email'. I have an open ticket at MultiSafepay regarding this issue.

disable_send_email is een functie welke alleen hoort te werken bij een BankTransfer/Bankoverboeking. Dit heeft alleen betrekking op de email met bankinstructies. Echter deze functie/variabele werkt op dit moment niet.

Roughly translates to:

disable_send_email is a function which is supposed to work for BankTransfer/Bankoverboeking. It is used for the email containing the bank (transfer) instructions. Though this function / variable is currently not functional.

I'll save you the the thread of messages before and after. In short they have confirmed that it should be 'disable_send_email' and it is only applicable to BankTransfers, but it is currently not functioning as expected (not functioning at all). I expect them to fix this in the upcoming weeks.

[edited typo]

@delatbabel
Copy link
Contributor

Good to hear, thanks for the information. OK well I will leave this on the dev branch untagged. If you get a better response which includes "MultiSafePay fixed the problems at their end" and also "I tested this in production and it works for me" then I will tag. Thanks for the translation efforts, too, my skill in Dutch is limited to knowing some interesting swear words that a school friend taught me many years ago.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants