Merge pull request #2 from jasonvarga/master

Change items parameter to a string
thephpleague · Jan 14, 2015 · a0f09ab · a0f09ab
2 parents 29f1b79 + 8b460fb
commit a0f09ab
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 5 deletions.
diff --git a/src/Message/PurchaseRequest.php b/src/Message/PurchaseRequest.php
@@ -138,9 +138,17 @@ public function getData()
         $transaction->addChild('var1', $this->getExtraData1());
         $transaction->addChild('var2', $this->getExtraData2());
         $transaction->addChild('var3', $this->getExtraData3());
-        $transaction->addChild('items', $this->getItems());
         $transaction->addChild('gateway', $this->getGateway());
 
+        if ($items = $this->getItems()) {
+            $itemsHtml = '<ul>';
+            foreach ($items as $item) {
+                $itemsHtml .= "<li>{$item['quantity']} x {$item['name']}</li>";
+            }
+            $itemsHtml .= '</ul>';
+            $transaction->addChild('items', $itemsHtml);
+        }
+
         if ('IDEAL' === $this->getGateway() && $this->getIssuer()) {
             $gatewayInfo = $data->addChild('gatewayinfo');
             $gatewayInfo->addChild('issuerid', $this->getIssuer());

diff --git a/tests/Message/PurchaseRequestTest.php b/tests/Message/PurchaseRequestTest.php
@@ -32,7 +32,10 @@ protected function setUp()
             'extraData2' => 'extra 2',
             'extraData3' => 'extra 3',
             'language' => 'a language',
-            'items' => 'the items',
+            'items' => array(
+                array('name' => 'item 1', 'quantity' => 1),
+                array('name' => 'item 2', 'quantity' => 2)
+            ),
             'clientIp' => '127.0.0.1',
             'googleAnalyticsCode' => 'analytics code',
             'card' => array(
@@ -165,8 +168,8 @@ public function allDataProvider()
     <var1>extra 1</var1>
     <var2>extra 2</var2>
     <var3>extra 3</var3>
-    <items>the items</items>
     <gateway>IDEAL</gateway>
+    <items>&lt;ul&gt;&lt;li&gt;1 x item 1&lt;/li&gt;&lt;li&gt;2 x item 2&lt;/li&gt;&lt;/ul&gt;</items>
   </transaction>
   <gatewayinfo>
     <issuerid>issuer</issuerid>
@@ -216,8 +219,8 @@ public function noIssuerDataProvider()
     <var1>extra 1</var1>
     <var2>extra 2</var2>
     <var3>extra 3</var3>
-    <items>the items</items>
     <gateway>another</gateway>
+    <items>&lt;ul&gt;&lt;li&gt;1 x item 1&lt;/li&gt;&lt;li&gt;2 x item 2&lt;/li&gt;&lt;/ul&gt;</items>
   </transaction>
   <signature>ad447bab87b8597853432c891e341db1</signature>
 </redirecttransaction>
@@ -264,8 +267,8 @@ public function specialCharsDataProvider()
     <var1>extra 1</var1>
     <var2>extra 2</var2>
     <var3>extra 3</var3>
-    <items>the items</items>
     <gateway>IDEAL</gateway>
+    <items>&lt;ul&gt;&lt;li&gt;1 x item 1&lt;/li&gt;&lt;li&gt;2 x item 2&lt;/li&gt;&lt;/ul&gt;</items>
   </transaction>
   <gatewayinfo>
     <issuerid>issuer</issuerid>