Show IP / username in history

Closes #932
theotherp · Mar 25, 2024 · f2136a1 · f2136a1
1 parent ca807b4
commit f2136a1
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 3 deletions.
diff --git a/core/src/main/resources/changelog.yaml b/core/src/main/resources/changelog.yaml
@@ -1,4 +1,9 @@
 #@formatter:off
+-   version: "v5.4.0"
+    changes:
+      -   type: "fix"
+          text: "IPs or usernames were not shown in the history. See #932"
+    final: true
 -   version: "v5.3.11"
     date: "2024-03-23"
     changes:

diff --git a/core/src/main/resources/static/js/nzbhydra.js b/core/src/main/resources/static/js/nzbhydra.js
@@ -10920,7 +10920,7 @@ function SearchHistoryController($scope, $state, SearchHistoryService, ConfigSer
 
     var anyUsername = false;
     var anyIp = false;
-    for (var request in $scope.searchRequests) {
+    for (var request of $scope.searchRequests) {
         if (request.username) {
             anyUsername = true;
         }
@@ -10931,6 +10931,7 @@ function SearchHistoryController($scope, $state, SearchHistoryService, ConfigSer
             break;
         }
     }
+
     $scope.columnSizes = {
         time: 10,
         query: 30,

diff --git a/core/src/main/resources/static/js/nzbhydra.js.map b/core/src/main/resources/static/js/nzbhydra.js.map
diff --git a/core/ui-src/js/search-history-controller.js b/core/ui-src/js/search-history-controller.js
@@ -34,7 +34,7 @@ function SearchHistoryController($scope, $state, SearchHistoryService, ConfigSer
 
     var anyUsername = false;
     var anyIp = false;
-    for (var request in $scope.searchRequests) {
+    for (var request of $scope.searchRequests) {
         if (request.username) {
             anyUsername = true;
         }
@@ -45,6 +45,7 @@ function SearchHistoryController($scope, $state, SearchHistoryService, ConfigSer
             break;
         }
     }
+
     $scope.columnSizes = {
         time: 10,
         query: 30,