Use oldabi libroot file when compiling with clang < 12.0.0 #796
+16
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrGcGamer
reviewed
May 3, 2024
|
Can we get this merged? Without this PR, compiling older tweaks using the Xcode 11 toolchain (for arm64e support) is broken. |
PoomSmart
approved these changes
May 8, 2024
L1ghtmann
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
RIght now compilation for oldabi fails due to libroot only having a new ABI file.
Initially I tried using a patched lipo to combine both old ABI and new ABI slices into the same .a, this however does not work.
Now there are two .a files, one with an old ABI arm64e slice and one with a new one and we use the correct one based on the clang version being used when compiling.
Depends on theos/lib#23 being merged first.
Does this close any currently open issues?
No
Where has this been tested?
Operating System: macOS
Target Platform: iOS