You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
What does this implement/fix? Explain your changes.
Adds variable to toggle codesigning
Does this close any currently open issues?
No
Any relevant logs, error output, etc?
Any other comments?
Seems there have been times when users have wanted to disable automatic codesigning for one reason or another and have had to resort to setting TARGET_CODESIGN to gibberish to get the check to pass without being overridden to a default. Now, setting SKIP_CODESIGN=1 will skip codesigning for the given instance. Confirmed via otool.
Placing this here as it seems this may need further review. The codesign step isn't necessary for all platforms, so TARGET_CODESIGN is set in darwin_head.mk instead of the given platform.mk. The check in instance/rules.mk, which is modified here, handles the codesign command itself, where it's blank for non-Darwin platforms that lack TARGET_CODESIGN. Blanking TARGET_CODESIGN in the Makefile of a project targeting iOS does nothing as darwin_heaad will set it ldid. However, passing TARGET_CODESIGN= to a make invocation for such a project does correctly blank the var and skip the codesigning step. May be able to avoid the addition proposed here if this logic can be adjusted.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
Adds variable to toggle codesigning
Does this close any currently open issues?
No
Any relevant logs, error output, etc?
Any other comments?
Seems there have been times when users have wanted to disable automatic codesigning for one reason or another and have had to resort to setting
TARGET_CODESIGNto gibberish to get the check to pass without being overridden to a default. Now, settingSKIP_CODESIGN=1will skip codesigning for the given instance. Confirmed viaotool.Where has this been tested?
Operating System: …
Linux (WSL)
Platform: …
Target Platform: …
Toolchain Version: …
SDK Version: …